Skip to content

Fix mimetype detection for junked uploads - #10828

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/fac-108/mimetype-detection-broken-for-junked-uploads
Aug 24, 2018
Merged

Fix mimetype detection for junked uploads#10828
MorrisJobke merged 1 commit into
masterfrom
bugfix/fac-108/mimetype-detection-broken-for-junked-uploads

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Fixnextcloud/files_accesscontrol#108

  1. Enable Files access control
  2. Add rule to block file mimetype is application/x-ms-dos-executable
  3. Download one from https://download.nextcloud.com/desktop/releases/Windows/
  4. Upload it
  5. Should be blocked, but still works.

Signed-off-by: Joas Schilling <coding@schilljs.com>

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really add integration tests for this as well.

@rullzerrullzer mentioned this pull request Aug 24, 2018
3 tasks

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit d8e876c into masterAug 24, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/fac-108/mimetype-detection-broken-for-junked-uploads branch August 24, 2018 15:23
@MorrisJobkeMorrisJobke mentioned this pull request Aug 24, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@rullzer@MorrisJobke