LIMIT is no column but a SQL keyword, allow limit on initial sync

[georgehrke]

fixes#9339

please test @rfc2822

[nickvergessen]

Should really move to the query builder at some time

[georgehrke]

I will take out the additional limit code and put it into a dedicated pull-request because it needs more testing ...

[rfc2822]

The first part (removing the `s) is working here fine :)

---

I'd not use the other part (allow limit on initial sync) this way because it returns the wrong sync-token ($currentToken instead of the sync-token that matches the sync state after applying the limit nresults) and thus breaks synchronization (which doesn't happen when the limit is silently ignored).

Support for client-requested limiting (truncating) is not required by the RFC, so maybe just throwing 507 on initial syncs with limit nresults would be a good idea (like https://tools.ietf.org/html/rfc6578#section-3.12)?

[blizzz]

set the milestone to 15 as this PR is against master.

[rullzer]

Moved it to the query builder (just so we keep cleaning up bit by bit).
@georgehrke please have a look as well.

If all is green we just need to rebase.

[MorrisJobke]

Code looks good 👍

[rullzer]

CI is not happy. Seems that @georgehrke added the order by which is not present.

[blizzz]

@georgehrke ^ ?

[MorrisJobke]

Moved to 15.0.1

[MorrisJobke]

Needs some work, on it ...

@georgehrke What is the status? We are close to the beta 1. 17 or 18?

[georgehrke]

@georgehrke What is the status? We are close to the beta 1. 17 or 18?

Let me put it onto my ToDo list for tomorrow.

[MorrisJobke]

Let me put it onto my ToDo list for tomorrow.

Tomorrow was yesterday, right? 😉

[georgehrke]

Test fresh sync with limit:

curl -X REPORT -u admin:batQz-Nc6zK-din8a-pdXoC-QPeWH -d '<?xml version="1.0" encoding="utf-8" ?>
<D:sync-collection xmlns:D="DAV:">
<D:sync-token/>
<D:sync-level>1</D:sync-level>
<D:limit>
<D:nresults>1</D:nresults>
</D:limit>
<D:prop>
<D:getetag/>
</D:prop>
</D:sync-collection>' 'http://nextcloud.local/remote.php/dav/calendars/admin/personal/'

=> Throws an exception

Test fresh sync without limit:

curl -X REPORT -u admin:batQz-Nc6zK-din8a-pdXoC-QPeWH -d '<?xml version="1.0" encoding="utf-8" ?>
<D:sync-collection xmlns:D="DAV:">
<D:sync-token/>
<D:sync-level>1</D:sync-level>
<D:prop>
<D:getetag/>
</D:prop>
</D:sync-collection>' 'http://nextcloud.local/remote.php/dav/calendars/admin/personal/'

=> Returns a list of all events

Test with sync-token and limit:

curl -X REPORT -u admin:batQz-Nc6zK-din8a-pdXoC-QPeWH -d '<?xml version="1.0" encoding="utf-8" ?>
<D:sync-collection xmlns:D="DAV:">
<D:sync-token>http://sabre.io/ns/sync/55</D:sync-token>
<D:sync-level>1</D:sync-level>
<D:limit>
<D:nresults>1</D:nresults>
</D:limit>
<D:prop>
<D:getetag/>
</D:prop>
</D:sync-collection>' 'http://nextcloud.local/remote.php/dav/calendars/admin/personal/'

=> Behaviour didn't change compared to master

Test with sync-token and without limit:

curl -X REPORT -u admin:batQz-Nc6zK-din8a-pdXoC-QPeWH -d '<?xml version="1.0" encoding="utf-8" ?>
<D:sync-collection xmlns:D="DAV:">
<D:sync-token>http://sabre.io/ns/sync/55</D:sync-token>
<D:sync-level>1</D:sync-level>
<D:limit>
<D:nresults>1</D:nresults>
</D:limit>
<D:prop>
<D:getetag/>
</D:prop>
</D:sync-collection>' 'http://nextcloud.local/remote.php/dav/calendars/admin/personal/'

=> Behaviour didn't change compared to master

[georgehrke]

I changed this PR as per @rfc2822's suggestion.
When a client sends an initial sync-request with a limit, we respond with a {DAV:}:number-of-matches-within-limits error

[MorrisJobke]

Code makes sense 👍