Skip to content

Fix icons cacher regex for compressed output - #10847

Merged
nickvergessen merged 1 commit into
masterfrom
fix-icons-cacher
Sep 19, 2018
Merged

Fix icons cacher regex for compressed output#10847
nickvergessen merged 1 commit into
masterfrom
fix-icons-cacher

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Aug 24, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

Fix#11131

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews feature: scss feature: caching Related to our caching system: scssCacher, jsCombiner... labels Aug 24, 2018
@skjnldsvskjnldsv added this to the Nextcloud 14 milestone Aug 24, 2018
@skjnldsvskjnldsv self-assigned this Aug 24, 2018
@MorrisJobke

MorrisJobke commented Aug 25, 2018

Copy link
Copy Markdown
Member

@skjnldsv many acceptance tests fail

@MorrisJobke

MorrisJobke commented Aug 25, 2018

Copy link
Copy Markdown
Member

Old CI job: https://drone.nextcloud.com/nextcloud/server/9903
Retriggered one: https://drone.nextcloud.com/nextcloud/server/9908

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 25, 2018
@rullzer

rullzer commented Aug 26, 2018

Copy link
Copy Markdown
Member

Acceptence tests are not happy: https://drone.nextcloud.com/nextcloud/server/9918

@rullzerrullzer added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Aug 26, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Aug 26, 2018
Merged
6 tasks
@skjnldsv

skjnldsv commented Aug 26, 2018

Copy link
Copy Markdown
MemberAuthor

Wow, this change is generating an error 500 on every acceptance test! 😕

@skjnldsv

skjnldsv commented Aug 26, 2018

Copy link
Copy Markdown
MemberAuthor

@danxuliu any ideas?

@vwbusguy

vwbusguy commented Aug 30, 2018•
edited
Loading

Copy link
Copy Markdown

Does the test environment have the Bookmarks app enabled or one of the others that currently causes 500s in 14rc1? That would explain the missing element on the apps page, etc. Re: #10920 and nextcloud/bookmarks#542
I can't imagine how this valid regex change for CSS would have any of these effects.

@vwbusguyvwbusguy mentioned this pull request Aug 30, 2018
Closed
@MorrisJobke

MorrisJobke commented Aug 30, 2018

Copy link
Copy Markdown
Member

Does the test environment have the Bookmarks app enabled or one of the others that currently causes 500s in 14rc1? That would explain the missing element on the apps page, etc. Re: #10920 and nextcloud/bookmarks#542

No - the tests are server core only.

@rullzer

rullzer commented Aug 30, 2018

Copy link
Copy Markdown
Member

14 or 15?

@skjnldsv

skjnldsv commented Aug 30, 2018

Copy link
Copy Markdown
MemberAuthor

@rullzer this is a required fix for 14, but I cannot find a proper way to do so :(
This is not a hardbreaking change though. Just affect the dark theme that is set as 'beta' anyway.

@MorrisJobke

MorrisJobke commented Aug 30, 2018

Copy link
Copy Markdown
Member

@rullzer this is a required fix for 14, but I cannot find a proper way to do so :(
This is not a hardbreaking change though. Just affect the dark theme that is set as 'beta' anyway.

Let's not block the 14.0.0 release then.

@skjnldsv

skjnldsv commented Aug 30, 2018

Copy link
Copy Markdown
MemberAuthor

I'm fine with that!

@rullzer

rullzer commented Sep 4, 2018

Copy link
Copy Markdown
Member

@danxuliu any idea why this breaks everything?

@skjnldsvskjnldsv mentioned this pull request Sep 10, 2018
Closed
@danxuliu

danxuliu commented Sep 18, 2018

Copy link
Copy Markdown
Member

any idea why this breaks everything?

Finally I do; the acceptance tests in this pull request should no longer fail if it is rebased after #11268 is merged.

@nickvergessennickvergessen mentioned this pull request Sep 19, 2018
Merged
@blizzz

blizzz commented Sep 19, 2018

Copy link
Copy Markdown
Member

set milestone to 15 as it is against master.

@skjnldsv@danxuliu
Fix icons cacher regex for compressed output
3095ec4
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@danxuliudanxuliu added 3. to review Waiting for reviews and removed help wanted 2. developing Work in progress labels Sep 19, 2018
@danxuliu

danxuliu commented Sep 19, 2018

Copy link
Copy Markdown
Member

Rebased onto master now that #11268 was merged.

@skjnldsv

skjnldsv commented Sep 19, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Failure looks unrelated, I restarted just in case.

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 19, 2018
@skjnldsv

skjnldsv commented Sep 19, 2018

Copy link
Copy Markdown
MemberAuthor

That's what I thought @nickvergessen can you merge? :)

@skjnldsvskjnldsv mentioned this pull request Sep 19, 2018
Merged
@nickvergessen
nickvergessen merged commit 12977a2 into masterSep 19, 2018
@nickvergessen
nickvergessen deleted the fix-icons-cacher branch September 19, 2018 14:00
@meminens

meminens commented Nov 5, 2018

Copy link
Copy Markdown

Same issue? nextcloud/tasks#214

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: cachingRelated to our caching system: scssCacher, jsCombiner...feature: scsshigh

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

9 participants

@skjnldsv@MorrisJobke@rullzer@vwbusguy@danxuliu@blizzz@meminens@juliusknorr@nickvergessen