Uh oh!
There was an error while loading. Please reload this page.
Added Drozone to favorites quickaccess - #10908
Closed
newhinton wants to merge 5 commits into
Closed
Conversation
newhinton
requested review from
MorrisJobke, danxuliu, jancborchardt and skjnldsvAugust 28, 2018 16:30
Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
…ntry from the list if it was already present Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
skjnldsvforce-pushed
the
feature/noid/favorites-quickaccess-add-droppable-v2
branch
from
October 2, 2018 06:18
6bd1ea6 to
d96a4d2Compareskjnldsv
requested changes
Oct 2, 2018
skjnldsv
left a comment
Member
There was a problem hiding this comment.
- The drop background stays after I stopped dragging :)
- If you remove the last directory from the favorite and add a new one it doesn't get appended to the quickaccess list :)
Otherwise it works great on files and folder!
newhinton
commented
Oct 2, 2018
ContributorAuthor
If i remember correctly #10888 should fix the second isssue, but ill have to look into the first one :D |
MorrisJobke
commented
Oct 2, 2018
Member
@newhinton Just change the labels from "2. developing" to "3. to review" once you are done with your changes ;) |
MorrisJobke
commented
Oct 24, 2018
Member
@newhinton Could you rebase this one please? Thanks :) |
MorrisJobke
commented
Nov 8, 2018
Member
Let's move this one to 16. |
newhinton
commented
Dec 7, 2018
ContributorAuthor
See #12917 |
Member
@newhinton so should we close this in favor of #12917 ? |
newhinton
commented
Dec 21, 2018
ContributorAuthor
@jancborchardt yes, i wasnt shure if it was the proper thing todo ;) |
jancborchardt
deleted the
feature/noid/favorites-quickaccess-add-droppable-v2
branch
December 21, 2018 02:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to drop a folder on the quickaccess and add it to it