Skip to content

Added kinetic scrolling for iOS to apps dropdown menu - #11111

Merged
MorrisJobke merged 1 commit into
nextcloud:masterfrom
kevin147147:patch-4
Oct 2, 2018
Merged

Added kinetic scrolling for iOS to apps dropdown menu#11111
MorrisJobke merged 1 commit into
nextcloud:masterfrom
kevin147147:patch-4

Conversation

@kevin147147

Copy link
Copy Markdown
Contributor

this is tested with nc14

@kevin147147

Copy link
Copy Markdown
ContributorAuthor

#10281

@kevin147147kevin147147 changed the title Added kinetic scrolling for iOS to apps dropdown menu #10281Added kinetic scrolling for iOS to apps dropdown menuSep 7, 2018
@ChristophWurstChristophWurst added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Sep 10, 2018
@ChristophWurst

Copy link
Copy Markdown
Member

Btw, nice pull request id 😉

@skjnldsv

Copy link
Copy Markdown
Member

@kevin147147 I thought we already checked on the last pr and the kinetic scroll was already by default on the apple browsers? 🤔

@kevin147147

Copy link
Copy Markdown
ContributorAuthor

Kinetic scroll is always opt in as far as i know

@skjnldsv

Copy link
Copy Markdown
Member

Great addition for ios yes :)

@skjnldsv

Copy link
Copy Markdown
Member

@kevin147147 You need to sign your commit for the tests to pass :)

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works nicely 👍

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw it working @MorrisJobke

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdesignDesign, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kevin147147@ChristophWurst@skjnldsv@rullzer@MorrisJobke