Skip to content

Update config and babel for ie11 - #11135

Merged
rullzer merged 3 commits into
masterfrom
babel-npm-webpack-fixes
Sep 26, 2018
Merged

Update config and babel for ie11#11135
rullzer merged 3 commits into
masterfrom
babel-npm-webpack-fixes

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Comment threadsettings/.babelrc
},
"modules": false,
"blacklist": ["useStrict"],
"useBuiltIns": true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those two not anymore?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they were not needed :)

@nickvergessen

Copy link
Copy Markdown
Member

Same should happen to all the apps in apps/ too I guess?

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Same should happen to all the apps in apps/ too I guess?

@nickvergessen Yes :)

@nickvergessen

Copy link
Copy Markdown
Member

@skjnldsv 14.0.1 backport? or 14.0.2?

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

@nickvergessen both are fine, :)

@rullzer

Copy link
Copy Markdown
Member

conflicts

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the babel-npm-webpack-fixes branch from d0f62ec to 8f05df2CompareSeptember 26, 2018 07:45

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure fine by me

@rullzer
rullzer merged commit bf57c53 into masterSep 26, 2018
@rullzer
rullzer deleted the babel-npm-webpack-fixes branch September 26, 2018 19:34
@MorrisJobke

Copy link
Copy Markdown
Member

@skjnldsv Mind to do the backport to stable14?

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Backport in #11490

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@nickvergessen@rullzer@MorrisJobke