Skip to content

Fix interaction with groups that contain a slash - #11200

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/2954/interaction-with-groups-containing-a-slash
Nov 15, 2018
Merged

Fix interaction with groups that contain a slash#11200
MorrisJobke merged 1 commit into
masterfrom
bugfix/2954/interaction-with-groups-containing-a-slash

Conversation

@nickvergessen

@nickvergessennickvergessen commented Sep 13, 2018•
edited by MorrisJobke
Loading

Copy link
Copy Markdown
Member

@skjnldsv can you help? The Vue-router seems to escape the placeholders
So when you open a group which contains a slash and reload the page, it breaks.

https://localhost/index.php/settings/users/test%2Fusers
with
https://localhost/index.php/settings/users/test/users it works quite fine.

Fixes#11110

@nickvergessennickvergessen added this to the Nextcloud 15 milestone Sep 13, 2018
skjnldsv
skjnldsv reviewed Sep 13, 2018
View reviewed changes
Comment threadsettings/src/router.js
children: [
{
path: ':selectedGroup',
path: ':selectedGroup(.*)',

@skjnldsvskjnldsvSep 13, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is working fine.
We need to encode the variables in the ocs requests instead.
Request URL: https://dev.skjnldsv.com/ocs/v2.php/cloud/groups/Test/1/users/details?offset=0&limit=25&search=
Should be /ocs/v2.php/cloud/groups/Test%2F1/users/details

@nickvergessennickvergessenSep 13, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the old URL works since Nextcloud 9 and should not require urlencoding all of a sudden.

@MorrisJobke

MorrisJobke commented Oct 3, 2018

Copy link
Copy Markdown
Member

It fixes #11110, right?

@MorrisJobkeMorrisJobke mentioned this pull request Oct 3, 2018
Closed
@skjnldsv

skjnldsv commented Oct 3, 2018

Copy link
Copy Markdown
Member

@MorrisJobke no idea :/

This was referenced Nov 7, 2018
Merged
Merged
@MorrisJobke

MorrisJobke commented Nov 14, 2018

Copy link
Copy Markdown
Member

@nickvergessen@skjnldsv Mind to rebase this one?

@nickvergessen@MorrisJobke
Fix interaction with groups that contain a slash
1997346
Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke
MorrisJobkeforce-pushed the bugfix/2954/interaction-with-groups-containing-a-slash branch from 129317d to 1997346CompareNovember 15, 2018 09:03
@MorrisJobke

MorrisJobke commented Nov 15, 2018

Copy link
Copy Markdown
Member

Rebased and rebuild the JS assets.

MorrisJobke
MorrisJobke approved these changes Nov 15, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 15, 2018
@MorrisJobke
MorrisJobke merged commit 4bf641f into masterNov 15, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/2954/interaction-with-groups-containing-a-slash branch November 15, 2018 09:30
@MorrisJobke

MorrisJobke commented Nov 22, 2018

Copy link
Copy Markdown
Member

/backport to stable14

@MorrisJobke

MorrisJobke commented Nov 22, 2018

Copy link
Copy Markdown
Member

/backport to stable13

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 22, 2018

Copy link
Copy Markdown

The backport to stable13 failed. Please do this backport manually.

1 similar comment
@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 22, 2018

Copy link
Copy Markdown

The backport to stable13 failed. Please do this backport manually.

@MorrisJobke

MorrisJobke commented Nov 29, 2018

Copy link
Copy Markdown
Member

/backport to stable14

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 29, 2018

Copy link
Copy Markdown

The backport to stable14 failed. Please do this backport manually.

@ChristophWurst

ChristophWurst commented Nov 29, 2018

Copy link
Copy Markdown
Member

/backport to stable15

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 29, 2018

Copy link
Copy Markdown

The backport to stable15 failed. Please do this backport manually.

@ChristophWurstChristophWurst mentioned this pull request Nov 29, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: users and groupsregression

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@MorrisJobke@skjnldsv@ChristophWurst