Uh oh!
There was an error while loading. Please reload this page.
Users page lazy multiselect group dropdowns - #1128
Merged
Merged
Conversation
added 3 commits
August 29, 2016 13:34
Instead of pre-rendering all multiselects with lots of group entries, the current groups are now displayed as simple labels. Behind the labels there is a pencil icon like for other fields. When clicking the pencil icon, the dropdown will be spawned and will open itself. Upon closing of the dropdown, the label comes back with the updated selection and the dropdown is destroyed.
mention-bot
commented
Aug 29, 2016
@blizzz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ringmaster, @icewind1991 and @tanghus to be potential reviewers |
karlitschek
commented
Aug 29, 2016
Member
agreed. please backport |
nickvergessen
commented
Aug 29, 2016
Member
Page loads really a lot faster now 👍 |
rullzer
commented
Aug 29, 2016
Member
LGTM |
blizzz pushed a commit
that referenced
this pull request
Aug 29, 2016
…le10 Users page lazy multiselect group dropdowns Instead of pre-rendering all multiselects with lots of group entries, the current groups are now displayed as simple labels. Behind the labels there is a pencil icon like for other fields. When clicking the pencil icon, the dropdown will be spawned and will open itself. Upon closing of the dropdown, the label comes back with the updated selection and the dropdown is destroyed. Extra non-available groups also in list Fix group sorting in user list group selection
blizzz pushed a commit
that referenced
this pull request
Aug 29, 2016
Users page lazy multiselect group dropdowns Instead of pre-rendering all multiselects with lots of group entries, the current groups are now displayed as simple labels. Behind the labels there is a pencil icon like for other fields. When clicking the pencil icon, the dropdown will be spawned and will open itself. Upon closing of the dropdown, the label comes back with the updated selection and the dropdown is destroyed. Extra non-available groups also in list Fix group sorting in user list group selection
blizzz
commented
Aug 29, 2016
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport from owncloud/core#25922
Improves rendering time of Users page. Upstream backported it down to 9.0, so i request also backporting this down to Nextcloud 9. @karlitschek
Please review @nickvergessen@icewind1991@LukasReschke