Skip to content

Copy the expiration from 480864b3e32d88361b17b70d238f986f64579757 to … - #11297

Merged
rullzer merged 2 commits into
masterfrom
bugfix/noid/this-database-dude
Sep 25, 2018
Merged

Copy the expiration from 480864b3e32d88361b17b70d238f986f64579757 to …#11297
rullzer merged 2 commits into
masterfrom
bugfix/noid/this-database-dude

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

…getTokenById

Signed-off-by: Joas Schilling coding@schilljs.com

Signed-off-by: Joas Schilling <coding@schilljs.com>

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bugfix/noid/this-database-dude

🙈

@kesselb

kesselb commented Sep 19, 2018

Copy link
Copy Markdown
Contributor

I see the same for

if ($token->getExpires() !== null && $token->getExpires() < $this->time->getTime()) {
where getToken and getTokenById differs

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

@danielkesselberg nice catch, added

@rullzer
rullzer merged commit 92fa373 into masterSep 25, 2018
@rullzer
rullzer deleted the bugfix/noid/this-database-dude branch September 25, 2018 07:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@kesselb@rullzer@ChristophWurst