Skip to content

Make the data year in the template dynamic by using date(). - #11304

Merged
MorrisJobke merged 2 commits into
nextcloud:masterfrom
andyg5000:master
Feb 1, 2019
Merged

Make the data year in the template dynamic by using date().#11304
MorrisJobke merged 2 commits into
nextcloud:masterfrom
andyg5000:master

Conversation

@andyg5000

@andyg5000andyg5000 commented Sep 20, 2018

Copy link
Copy Markdown
Contributor

Simple fix to the example template file to make the copyright date dynamic

@splitt3r

splitt3r commented Sep 20, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

The \ should be removed too, should it? And the doc link url. And perhaps a docblock for that ^^.^And what about getLongFooter?

@andyg5000

andyg5000 commented Sep 20, 2018

Copy link
Copy Markdown
ContributorAuthor

Oh geez, good point ;) I'll review the whole file and report back :P

@MorrisJobkeMorrisJobke added the 2. developing Work in progress label Sep 26, 2018
@ChristophWurst

ChristophWurst commented Jan 28, 2019

Copy link
Copy Markdown
Member

@andyg5000 🏓 any updates? I think this is a nice fix :)

@ChristophWurst

ChristophWurst commented Jan 30, 2019

Copy link
Copy Markdown
Member

@splitt3r if you know what's missing it would be great if you could help move this forward :)

@ChristophWurstChristophWurst added 1. to develop Accepted and waiting to be taken care of enhancement and removed 2. developing Work in progress labels Jan 30, 2019
@splitt3r

splitt3r commented Jan 31, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@ChristophWurst ready to review 👍

ChristophWurst
ChristophWurst approved these changes Jan 31, 2019
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ChristophWurstChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 31, 2019
@ChristophWurstChristophWurst added this to the Nextcloud 16 milestone Jan 31, 2019
kesselb
kesselb reviewed Jan 31, 2019
View reviewed changes
Comment threadthemes/example/defaults.php
MorrisJobke
MorrisJobke approved these changes Feb 1, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change makes sense 👍

@MorrisJobke

MorrisJobke commented Feb 1, 2019

Copy link
Copy Markdown
Member

I rebased this to trigger CI again (because it was using old steps that failed).

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 1, 2019
@MorrisJobke
MorrisJobke merged commit 422dd9d into nextcloud:masterFeb 1, 2019
@welcome

welcomeBot commented Feb 1, 2019

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@kesselbkesselb mentioned this pull request Mar 15, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb left review comments
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@rullzerrullzerAwaiting requested review from rullzer
+1 more reviewer
@splitt3rsplitt3rsplitt3r left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@andyg5000@splitt3r@ChristophWurst@MorrisJobke@kesselb