Skip to content

Add back the total used space per user - #11417

Merged
skjnldsv merged 4 commits into
masterfrom
hover-quota-used-space-regression
Sep 28, 2018
Merged

Add back the total used space per user#11417
skjnldsv merged 4 commits into
masterfrom
hover-quota-used-space-regression

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Sep 27, 2018

Copy link
Copy Markdown
Member

@skjnldsv
Add back the total used space per user
1aa0990
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added this to the Nextcloud 15 milestone Sep 27, 2018
@skjnldsvskjnldsv self-assigned this Sep 27, 2018
@skjnldsv
Fix string formatting
7c15d9e
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
JSoko
JSoko approved these changes Sep 27, 2018
View reviewed changes

@JSokoJSoko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works, thank You!

@rullzer

rullzer commented Sep 27, 2018

Copy link
Copy Markdown
Member

CI not happy

ChristophWurst
ChristophWurst approved these changes Sep 28, 2018
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

Can be merged once CI is happy

@JSoko

JSoko commented Sep 28, 2018

Copy link
Copy Markdown
Member

One small thing:
For users who use 0kb ist shows "unknown Space used"
Bug or feauture?
grafik

@skjnldsv

skjnldsv commented Sep 28, 2018

Copy link
Copy Markdown
MemberAuthor

@JSoko feature. The user did not logged in yet so the user folder doesn't exists.
Though I can say it's better for the user to see 0kb used even if it's not really true :)

I'll change this!

@skjnldsv
Fix class selector for acceptance tests
f5f31e2
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
State default unknown quota to 0
8a2ac44
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsv merged commit ecf33a6 into masterSep 28, 2018
@skjnldsv
skjnldsv deleted the hover-quota-used-space-regression branch September 28, 2018 06:59
@skjnldsvskjnldsv mentioned this pull request Sep 28, 2018
Merged
@skjnldsv

skjnldsv commented Sep 28, 2018

Copy link
Copy Markdown
MemberAuthor

Backport on #11425

This was referenced Oct 3, 2018
Closed
Closed
@nextcloud-botnextcloud-bot mentioned this pull request Oct 11, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@JSokoJSokoJSoko approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: users and groupsregression

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@rullzer@JSoko@ChristophWurst