Skip to content

Fix acceptance tests as app title changed - #11422

Merged
rullzer merged 1 commit into
stable14from
fix/acceptance-apps
Sep 28, 2018
Merged

Fix acceptance tests as app title changed#11422
rullzer merged 1 commit into
stable14from
fix/acceptance-apps

Conversation

@rullzer

Copy link
Copy Markdown
Member

The redundant app was removed. So we need to update the tests to make it
green.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

The redundant app was removed. So we need to update the tests to make it
green.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added the 3. to review Waiting for reviews label Sep 27, 2018
@rullzerrullzer added this to the Nextcloud 14.0.2 milestone Sep 27, 2018

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okidoke

@ChristophWurst

Copy link
Copy Markdown
Member

So we need to update the tests to make it
green.

**continuous-integration/drone/pr ** — the build failed

I see 🤔

@danxuliu

Copy link
Copy Markdown
Member

**continuous-integration/drone/pr ** — the build failed

I see 🤔

It is caused by the integration tests on PostgreSQL, but the acceptance tests are fixed as expected by this pull request ;-)

@ChristophWurst

Copy link
Copy Markdown
Member

Thanks for the info @danxuliu. I was just too lazy to look and found it amusing that a PR claiming to fix CI has failing CI 😉

@rullzer
rullzer merged commit c12689b into stable14Sep 28, 2018
@rullzer
rullzer deleted the fix/acceptance-apps branch September 28, 2018 07:16
@MorrisJobkeMorrisJobke mentioned this pull request Oct 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@ChristophWurst@danxuliu