Skip to content

Fix invalid inline input confirm border - #11423

Merged
MorrisJobke merged 2 commits into
masterfrom
inline-input-error-fix
Sep 28, 2018
Merged

Fix invalid inline input confirm border#11423
MorrisJobke merged 2 commits into
masterfrom
inline-input-error-fix

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Sep 27, 2018

Copy link
Copy Markdown
Member
beforeAfter
capture d ecran_2018-09-27_22-01-30capture d ecran_2018-09-27_22-02-06

@nextcloud/designers

@skjnldsvskjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews backport-request labels Sep 27, 2018
@skjnldsvskjnldsv added this to the Nextcloud 15 milestone Sep 27, 2018
@skjnldsvskjnldsv self-assigned this Sep 27, 2018
@skjnldsv
Fix invalid inline input confirm border
e744b02
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the inline-input-error-fix branch from 2589d8a to e744b02CompareSeptember 28, 2018 07:29
@skjnldsv
TABS :D
4bfe88d
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
danxuliu
danxuliu approved these changes Sep 28, 2018
View reviewed changes

@danxuliudanxuliu left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (with an ad hoc form, not with the Contacts app as shown in the screenshot) and works 👍

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 28, 2018
@skjnldsv

skjnldsv commented Sep 28, 2018

Copy link
Copy Markdown
MemberAuthor

sh: 1: kill: No such process
Unrelated

@skjnldsvskjnldsv mentioned this pull request Sep 28, 2018
Merged
@MorrisJobke
MorrisJobke merged commit f6e39e5 into masterSep 28, 2018
@MorrisJobke
MorrisJobke deleted the inline-input-error-fix branch September 28, 2018 08:59
@jancborchardt

jancborchardt commented Oct 3, 2018

Copy link
Copy Markdown
Member

screenshot from 2018-10-03 16-24-51
🤔 😉

@skjnldsv

skjnldsv commented Oct 3, 2018

Copy link
Copy Markdown
MemberAuthor

@jancborchardt 😂😂

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@danxuliudanxuliudanxuliu approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@jancborchardtjancborchardtAwaiting requested review from jancborchardt

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugdesignDesign, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@jancborchardt@rullzer@danxuliu@MorrisJobke