Skip to content

Add uid_owner and uid_initiator share tabe indices - #11527

Merged
rullzer merged 1 commit into
masterfrom
fix/10926/share_indexes
Oct 2, 2018
Merged

Add uid_owner and uid_initiator share tabe indices#11527
rullzer merged 1 commit into
masterfrom
fix/10926/share_indexes

Conversation

@rullzer

@rullzerrullzer commented Oct 1, 2018

Copy link
Copy Markdown
Member

For #10926

@rullzer
Add uid_owner and uid_initiator share tabe indices
b82cbe0
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added enhancement 3. to review Waiting for reviews labels Oct 1, 2018
@rullzerrullzer added this to the Nextcloud 15 milestone Oct 1, 2018
@rullzer
rullzer merged commit ac8d4b2 into masterOct 2, 2018
@rullzer
rullzer deleted the fix/10926/share_indexes branch October 2, 2018 15:16
@Arvidas

Arvidas commented Nov 6, 2018

Copy link
Copy Markdown

if (!$table->hasIndex('owner_index'))
not if (!$table->hasIndex('uid_owner')) {
and so on

@MorrisJobke

MorrisJobke commented Nov 6, 2018

Copy link
Copy Markdown
Member

if (!$table->hasIndex('owner_index'))
not if (!$table->hasIndex('uid_owner')) {
and so on

🙈

@MorrisJobke

MorrisJobke commented Nov 6, 2018

Copy link
Copy Markdown
Member

Thanks for spotting this.

MorrisJobke added a commit that referenced this pull request Nov 6, 2018
@MorrisJobke
Fix index names
30e0544
* see #11527
MorrisJobke added a commit that referenced this pull request Nov 6, 2018
@MorrisJobke
Fix index names
4d20c42
* see #11527
@MorrisJobkeMorrisJobke mentioned this pull request Nov 6, 2018
Merged
@MorrisJobke

MorrisJobke commented Nov 6, 2018

Copy link
Copy Markdown
Member

Fix is in #12312

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@schiessleschiessleAwaiting requested review from schiessle

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@Arvidas@MorrisJobke@ChristophWurst