Skip to content

Accessibility and design fixes for update and redirect pages - #11557

Merged
rullzer merged 2 commits into
masterfrom
update-design
Oct 3, 2018
Merged

Accessibility and design fixes for update and redirect pages#11557
rullzer merged 2 commits into
masterfrom
update-design

Conversation

@jancborchardt

Copy link
Copy Markdown
Member
  • Regular links now have an underline effect on hover/focus. Makes more sense than the transparency on hover and looks especially nice in Webkit cause it does not cut through descenders.
  • The buttons now have hover/focus state for proper accessibility
  • Buttons have proper padding for clickability
  • Style update button as primary (blue)

Log in now, with nice hover/focus effect (there was none before):
screenshot from 2018-10-02 20-38-07

Redirect of Mail app before & after, had no hover/focus effect either. General style adjusted like the modal in #11536
screenshot from 2018-10-02 20-45-48
screenshot from 2018-10-02 20-38-44

Same for upgrade, had no hover/focus effect, and some spacing on top and bottom was fixed:
screenshot from 2018-10-02 20-42-38
screenshot from 2018-10-02 20-40-43

Please review @nextcloud/designers @nextcloud/accessibility

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
skjnldsv
skjnldsv previously requested changes Oct 2, 2018

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really fond of the shadow, feels too strange :)
I feel like when using opacity, having a neat delimitation is easier for us to find where to focus, but the eye tend to get confused by gradual shadow.

But the rest is 🔥 🔥 🔥

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt

Copy link
Copy Markdown
MemberAuthor

@skjnldsv removed the shadow! 🌞
screenshot from 2018-10-02 23-13-47

@MariusBluem

Copy link
Copy Markdown
Member

I liked it more with the shaddow to be honest 🤨🤭

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like it with the shadow 👍

@jancborchardt

Copy link
Copy Markdown
MemberAuthor

For the record: I also like it better with the shadow, but am also fine without. :) Let’s just get it in like this, we can do the shadow later.

@weeman1337weeman1337 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it more without the shadow. It somehow looks cleaner.
With shadow this also looks like the new rounded dialogs - but it isn't one...

@rullzer

Copy link
Copy Markdown
Member

Let me merge this now and you can discuss further changes in followup issues :)

@rullzer
rullzer merged commit 6979b2e into masterOct 3, 2018
@rullzer
rullzer deleted the update-design branch October 3, 2018 08:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: accessibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jancborchardt@MariusBluem@rullzer@MorrisJobke@weeman1337@skjnldsv