Skip to content

[stable14] Fix sticky header on users list - #11582

Merged
MorrisJobke merged 1 commit into
stable14from
stb14-users-table-header-fix
Oct 3, 2018
Merged

[stable14] Fix sticky header on users list#11582
MorrisJobke merged 1 commit into
stable14from
stb14-users-table-header-fix

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Backport Fix sticky header on users list #11581

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. feature: users and groups labels Oct 3, 2018
@skjnldsvskjnldsv added this to the Nextcloud 14.0.2 milestone Oct 3, 2018
@skjnldsvskjnldsv self-assigned this Oct 3, 2018
@skjnldsvskjnldsv changed the title Fix sticky header on users list[stable14] Fix sticky header on users listOct 3, 2018

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and I think @MorrisJobke tested it 👍 🙈

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍 (same as with the master PR: border at bottom would be nice, but I'm fine with a followup PR)

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2018
@MorrisJobke
MorrisJobke merged commit 5b33cbd into stable14Oct 3, 2018
@MorrisJobke
MorrisJobke deleted the stb14-users-table-header-fix branch October 3, 2018 12:54
@MorrisJobke
MorrisJobke restored the stb14-users-table-header-fix branch October 3, 2018 12:54
@ChristophWurst
ChristophWurst deleted the stb14-users-table-header-fix branch October 3, 2018 12:55
@MorrisJobkeMorrisJobke mentioned this pull request Oct 3, 2018
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke follow-up: #11608

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugdesignDesign, UI, UX, etc.feature: users and groupspapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@MorrisJobke@ChristophWurst