Skip to content

Update strengthify to be able to set a nonce - #11592

Merged
rullzer merged 2 commits into
masterfrom
feature/noid/update-strengthify
Oct 3, 2018
Merged

Update strengthify to be able to set a nonce#11592
rullzer merged 2 commits into
masterfrom
feature/noid/update-strengthify

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Oct 3, 2018•
edited
Loading

Copy link
Copy Markdown
Member
  • actually set the correct nonce (see second commit)

For #11028

cc @rullzer

@MorrisJobkeMorrisJobke added the 2. developing Work in progress label Oct 3, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 15 milestone Oct 3, 2018
MorrisJobke
MorrisJobke commented Oct 3, 2018
View reviewed changes
Comment threadcore/js/setup.js Outdated
t('core', 'Strong password')
],
drawTitles: true,
nonce: 'TODO',

@MorrisJobkeMorrisJobkeOct 3, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using window.btoa(OC.requestToken) didn't worked for me - at least not the same nonce was created.

@MorrisJobke
Update strengthify
24c74b3
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Set nonce for loading the zxcvbn
c8e617b
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 3, 2018
@MorrisJobke
MorrisJobkeforce-pushed the feature/noid/update-strengthify branch from 2382ba6 to c8e617bCompareOctober 3, 2018 15:05
@MorrisJobke

MorrisJobke commented Oct 3, 2018

Copy link
Copy Markdown
MemberAuthor

Tested, works and rebased 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2018
@rullzer
rullzer merged commit f4387ed into masterOct 3, 2018
@rullzer
rullzer deleted the feature/noid/update-strengthify branch October 3, 2018 16:40
@snyk-botsnyk-bot mentioned this pull request Jul 18, 2020
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

@rullzerrullzer

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@ChristophWurst