Skip to content

Fix a misleading setup check for .well-known/caldav & carddav - #11733

Merged
ChristophWurst merged 1 commit into
masterfrom
fix/noid/misleading-well-known-check
Oct 10, 2018
Merged

Fix a misleading setup check for .well-known/caldav & carddav#11733
ChristophWurst merged 1 commit into
masterfrom
fix/noid/misleading-well-known-check

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

The problem is that the version without the slash is the correct one.

Caused by the fix of the check: #11411

I would also vote to get this into the 14.0.2 and 13.0.7 releases because otherwise everyone gets this error message which is plain wrong. :/

The problem is that the version without the slash is the correct one.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

This is basically a problem of the current Nginx config, nevertheless should it be a check on the URL without the slash only, because in our current .htaccess we only check if it matches the beginning of the URL and also /.well-known/caldav123456 would result in a proper redirect.

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

I just checked and this is the needed URL: /.well-known/caldav(see also the RFC: https://tools.ietf.org/html/rfc6764#section-9.1) and the access log when a macOS device connects:

192.168.1.1 - [10/Oct/2018:11:05:19 +0200] "PROPFIND /remote.php/dav HTTP/1.1" 401 569 "-" "Mac+OS+X/10.14 (18A391) accountsd/113" 0.034 0.034 .

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

I would also vote to get this into the 14.0.2 and 13.0.7 releases because otherwise everyone gets this error message which is plain wrong. :/

I was wrong on this one - it's only the Nginx config, which is still correct. We should add this to the release notes or should we put it into the releases this week?

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

@tflidd@rakekniven JFYI: If there is a report about "Your web server is not properly set up to resolve '/.well-known/caldav'" (or carddav) then this is due to this problem. Usually it works fine, but the check is simply wrong.

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. RFC should be followed here.

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Backport PRs are open now.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@ChristophWurst