Remove duplicate call to decodeURIComponent

[burned42]

In this code path the path variable got decoded twice which resulted in the bug described in #11695 because the second call seems to have caused an URIError.

I removed the second call to decodeURIComponent() which seems to have fixed this bug. I can now open the all files view with a file with a % in the name and it will show the list of files instead of just the spinning animation.

[juliusknorr]

👍 Makes sense

[ChristophWurst]

Origin: 8782004owncloud/core#22130 (@rullzer 👍'd hehe)

[burned42]

Thank for reviewing&merging :)

Since this got merged now, I guess I should also backport this to stable14 as @rullzer added the label backport-request, right? -> #11781

[hani2000]

Dear all,
14.03 has this bug, I tried the fix above and it does not work. The only thing that worked for me is removing or changing the names of files that contain "%" in their names.

Is there a patch or a fix identified for this issue? It seems more than the clients.js file

[ChristophWurst]

@hani2000https://github.com/nextcloud/server/commits/549d53cd93807270a18495a08dac72b24aabf5bb tells me this fix is not part of the 14.0.3 release.

[hani2000]

Actually, I tried it on an Opera versus Chrome, it seems the above fix works and it is only my browser cache

I know it is not part of 14.03, but since 14.03 is what is recommended to be installed so many people have this bug recking their web interface access. So I suggest releasing a quick fix.

[MorrisJobke]

I know it is not part of 14.03, but since 14.03 is what is recommended to be installed so many people have this bug recking their web interface access. So I suggest releasing a quick fix.

This one was introduced in #11151. The question here is if it really is that urgent to be fixed. Up until now 3 people reported this issue. I would not rush out a new maintenance release as of now. There is an easy fix that can be applied, if this is a problem. Up until then the next release is due in a few weeks (2018-11-22) and we should aim for that as of now.