Skip to content

Allow "same-origin" as "Referrer-Policy" - #11766

Merged
rullzer merged 1 commit into
nextcloud:masterfrom
Birkenstab:feature/allow-same-origin-referrer-policy
Oct 11, 2018
Merged

Allow "same-origin" as "Referrer-Policy"#11766
rullzer merged 1 commit into
nextcloud:masterfrom
Birkenstab:feature/allow-same-origin-referrer-policy

Conversation

@Birkenstab

@BirkenstabBirkenstab commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

Fixes#11531

Although "same-origin" is more strict than e.g. strict-origin it triggers a warning in setupcheck
Based on https://scotthelme.co.uk/a-new-security-header-referrer-policy/

I guess the translations of the warning message will stop working.

Signed-off-by: Moritz Beck git@birkenstab.de

@Birkenstab
Allow "same-origin" as "Referrer-Policy"
b68661e
Fixes#11531
Although "same-origin" is more strict than e.g. strict-origin it showed up a warning in setupcheck
Based on https://scotthelme.co.uk/a-new-security-header-referrer-policy/
Signed-off-by: Moritz Beck <git@birkenstab.de>
rullzer
rullzer approved these changes Oct 11, 2018
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep makes sense.

@rullzerrullzer added this to the Nextcloud 15 milestone Oct 11, 2018
@rullzer

rullzer commented Oct 11, 2018

Copy link
Copy Markdown
Member

@Birkenstab thanks :)

The translations will be updated via transifex :)

MorrisJobke
MorrisJobke approved these changes Oct 11, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 11, 2018
@rullzer
rullzer merged commit eed1e6e into nextcloud:masterOct 11, 2018
@Birkenstab
Birkenstab deleted the feature/allow-same-origin-referrer-policy branch October 11, 2018 13:30
@MorrisJobke

MorrisJobke commented Oct 19, 2018

Copy link
Copy Markdown
Member

@Birkenstab Mind to open the backport PR? This basically means you checkout stable14, branch off a new branch, use git cherry-pick to apply the commit from here to it and push that as a base for a pull request against stable14. ;)

@Birkenstab

Birkenstab commented Oct 20, 2018

Copy link
Copy Markdown
ContributorAuthor

@MorrisJobke Sure #11950

@nextcloud-botnextcloud-bot mentioned this pull request Nov 27, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

3 participants

@Birkenstab@rullzer@MorrisJobke