Skip to content

[14] Allow overwrite.cli.url without trailing slash - #11772

Merged
MorrisJobke merged 1 commit into
stable14from
stable14-pretty-urls-dont-work
Oct 19, 2018
Merged

[14] Allow overwrite.cli.url without trailing slash#11772
MorrisJobke merged 1 commit into
stable14from
stable14-pretty-urls-dont-work

Conversation

@kesselb

@kesselbkesselb commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

Backport #11446

@kesselb
Backport#11446
4f983b7
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselbkesselb added the bug label Oct 11, 2018
@kesselbkesselb added this to the Nextcloud 14.0.3 milestone Oct 11, 2018
@kesselbkesselb changed the title Backport https://github.com/nextcloud/server/pull/11446[14] Allow overwrite.cli.url without trailing slashOct 11, 2018
@kesselbkesselb added the 3. to review Waiting for reviews label Oct 11, 2018
@juliusknorr

juliusknorr commented Oct 12, 2018

Copy link
Copy Markdown
Member

Failing tests seem unrelated

All postgres:

Error while trying to create admin user: Failed to connect to the database: An exception occured in driver: SQLSTATE[08006] [7] FATAL: permission denied for database "oc_autotest"
DETAIL: User does not have CONNECT privilege.

@MorrisJobke

MorrisJobke commented Oct 12, 2018

Copy link
Copy Markdown
Member

All postgres:

Happens sometimes :/

@MorrisJobke
MorrisJobke merged commit 2885db8 into stable14Oct 19, 2018
@MorrisJobke
MorrisJobke deleted the stable14-pretty-urls-dont-work branch October 19, 2018 10:16
@MorrisJobkeMorrisJobke mentioned this pull request Nov 13, 2018
Merged
@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 14.0.4

Development

Successfully merging this pull request may close these issues.

3 participants

@kesselb@juliusknorr@MorrisJobke