Skip to content

[14] php7.3 CI - #11790

Merged
rullzer merged 2 commits into
stable14from
backport/11745/stable14
Oct 12, 2018
Merged

[14] php7.3 CI#11790
rullzer merged 2 commits into
stable14from
backport/11745/stable14

Conversation

@rullzer

Copy link
Copy Markdown
Member

backport of #11745

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added the 3. to review Waiting for reviews label Oct 12, 2018
@rullzerrullzer added this to the Nextcloud 14.0.4 milestone Oct 12, 2018
@MorrisJobke

Copy link
Copy Markdown
Member

I would also love to see the acceptance tests to be run on PHP 7.3 🙈

@rullzer

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke agreed. I think they still run on 7.1 actually 🙊

@MorrisJobke

Copy link
Copy Markdown
Member

I would also love to see the acceptance tests to be run on PHP 7.3 🙈

But something for another PR.

@rullzer
rullzer merged commit 91c44c8 into stable14Oct 12, 2018
@rullzer
rullzer deleted the backport/11745/stable14 branch October 12, 2018 13:32
@MorrisJobkeMorrisJobke mentioned this pull request Nov 13, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@MorrisJobke@nickvergessen@blizzz