Skip to content

allow local delivery of schedule message while prohibiting FreeBusy requests - #11822

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/forbid_freebusy_but_allow_local_delivery
Oct 18, 2018
Merged

allow local delivery of schedule message while prohibiting FreeBusy requests#11822
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/forbid_freebusy_but_allow_local_delivery

Conversation

@georgehrke

@georgehrkegeorgehrke commented Oct 14, 2018

Copy link
Copy Markdown
Member

To test this you need a copy of thunderbird.

With php occ config:app:set dav disableFreeBusy --value=no (or option not set):

  • FreeBusy is allowed
    freebusy_setting_disabled
  • Invitations are delivered locally
    delivered_setting_disabled

With php occ config:app:set dav disableFreeBusy --value=yes

  • FreeBusy is prohibited
    freebusy_option_enabled
  • but local delivery is still working
    d0182040-b5c3-4b24-b7f1-157ef8715b85

With current master, enabling disableFreeBusy also breaks local delivery.

@georgehrkegeorgehrke added the 2. developing Work in progress label Oct 14, 2018
@georgehrkegeorgehrke added this to the Nextcloud 15 milestone Oct 14, 2018
@georgehrke
georgehrkeforce-pushed the bugfix/noid/forbid_freebusy_but_allow_local_delivery branch from 26532e0 to f077c64CompareOctober 14, 2018 11:55
@georgehrkegeorgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 16, 2018
@georgehrke
georgehrke requested review from MorrisJobke and rullzer and removed request for rullzerOctober 16, 2018 18:04
…Outbox collection. This allows to keep local delivery of scheduling messages while prohibiting FreeBusy requests
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
georgehrkeforce-pushed the bugfix/noid/forbid_freebusy_but_allow_local_delivery branch from f077c64 to f5dc7b7CompareOctober 16, 2018 18:27

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick for me

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke

Copy link
Copy Markdown
Member

CI failure unrelated.

@MorrisJobke
MorrisJobke merged commit 4e53ea6 into masterOct 18, 2018
@rullzer

Copy link
Copy Markdown
Member

@georgehrke since this is mainly tests and faily straight forward code.
How about a backport?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@georgehrke@MorrisJobke@rullzer