Uh oh!
There was an error while loading. Please reload this page.
Correctly handle multi-values when converting VCards to array - #1190
Merged
Conversation
mention-bot
commented
Aug 30, 2016
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @georgehrke and @DeepDiver1975 to be potential reviewers |
karlitschek
commented
Aug 30, 2016
Member
great. backport makes sense 👍 |
rullzer
commented
Aug 30, 2016
Member
Nice 👍 |
MorrisJobke
commented
Aug 30, 2016
Member
Tested and works 👍 |
nickvergessen
commented
Aug 31, 2016
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This affects "only" the php API of our implementation, not related to sync or whatever.
Steps
admin@nextcloud.com,admin@example.tldadmin@into the boxExpected
Two results for federated sharing:
Hello Testing (at nextcloud.com)Hello Testing (at example.tld)Actual
Only one result for federated sharing (the second cloud id you entered):
Hello Testing (at example.tld)@karlitschek requesting backport to 10 and 9, since this is quite heavy. The same happens for emails and addresses (used by calendar) and it also makes the activity app not finding matches when it's not the first cloud id.
@rullzer@MorrisJobke