Skip to content

Highlight 'Enable' button in sidebar, and 'Update' button generally - #11941

Merged
rullzer merged 1 commit into
masterfrom
app-mgmt-button-highlight
Oct 21, 2018
Merged

Highlight 'Enable' button in sidebar, and 'Update' button generally#11941
rullzer merged 1 commit into
masterfrom
app-mgmt-button-highlight

Conversation

@jancborchardt

@jancborchardtjancborchardt commented Oct 19, 2018

Copy link
Copy Markdown
Member
  • In the list, any "Update" button gets the primary class for highlight
  • In the sidebar also, and if the app isn’t enabled yet the enable button gets the primary class

Please review @nextcloud/designers (and disregard the rounded buttons, that’s a different pull request at #11943 ;)

buttons apps

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@ChristophWurst

Copy link
Copy Markdown
Member

I like those buttons 😎

@jancborchardt

Copy link
Copy Markdown
MemberAuthor

@ChristophWurst check out #11943 ;)

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I often thought we needed something like that! 👍

@rullzer
rullzer merged commit fa00639 into masterOct 21, 2018
@rullzer
rullzer deleted the app-mgmt-button-highlight branch October 22, 2018 06:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdesignDesign, UI, UX, etc.enhancementfeature: apps management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jancborchardt@ChristophWurst@rullzer@skjnldsv