Skip to content

[13] Do not emit preHooks twice on non-part-storage - #11962

Merged
MorrisJobke merged 1 commit into
stable13from
backport/11931/stable13
Oct 23, 2018
Merged

[13] Do not emit preHooks twice on non-part-storage#11962
MorrisJobke merged 1 commit into
stable13from
backport/11931/stable13

Conversation

@rullzer

Copy link
Copy Markdown
Member

Backport of #11931

The old code would emit the hooks twice. Thus having the version written
twice. Which is not very performant as it is first read twice as well.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added the 3. to review Waiting for reviews label Oct 21, 2018
@rullzerrullzer added this to the Nextcloud 13.0.8 milestone Oct 21, 2018

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke
MorrisJobke merged commit 56812b0 into stable13Oct 23, 2018
@MorrisJobke
MorrisJobke deleted the backport/11931/stable13 branch October 23, 2018 16:16
@MorrisJobkeMorrisJobke mentioned this pull request Nov 13, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@icewind1991