Skip to content

CalDAV calendar public sharing - #1197

Merged
LukasReschke merged 44 commits into
masterfrom
oc-public-sharing
Sep 27, 2016
Merged

CalDAV calendar public sharing#1197
LukasReschke merged 44 commits into
masterfrom
oc-public-sharing

Conversation

@LukasReschke

@LukasReschkeLukasReschke commented Aug 30, 2016

Copy link
Copy Markdown
Member

From owncloud/core#25351

Needs proper review and testing as there were some smaller conflicts. Will also myself go through it again as well.

@LukasReschkeLukasReschke added this to the Nextcloud 11.0 milestone Aug 30, 2016
@mention-bot

mention-bot commented Aug 30, 2016

Copy link
Copy Markdown

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @DeepDiver1975 and @tcitworld to be potential reviewers

@LukasReschkeLukasReschke added 2. developing Work in progress 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 2. developing Work in progress labels Aug 30, 2016
LukasReschke
LukasReschke reviewed Aug 30, 2016
View reviewed changes
Comment threadapps/dav/lib/CalDAV/CalDavBackend.php Outdated
* @param IDBConnection $db
* @param Principal $principalBackend
* @param IUserManager $userManager
* @param IConfig $config

@LukasReschkeLukasReschkeAug 30, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 1, 2016
@tcitworld

tcitworld commented Sep 19, 2016

Copy link
Copy Markdown
Member

Please review again. :)

@tcitworldtcitworld mentioned this pull request Sep 19, 2016
Merged
@tcitworld
tcitworldforce-pushed the oc-public-sharing branch 3 times, most recently from 66d11ce to d0c5d5aCompareSeptember 23, 2016 16:20
@MorrisJobke

MorrisJobke commented Sep 26, 2016

Copy link
Copy Markdown
Member

@schiessle Signed-off is missing here - how to handle this case?

@LukasReschke

LukasReschke commented Sep 26, 2016•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@schiessle Signed-off is missing here - how to handle this case?

Ignore. I won't touch every old PR and add a "Signed-off" at every commit (aka huge waste of time 🙈). Otherwise, @schiessle can happily volunteer for doing so and train his 10 finger typing system 🚀

@tcitworld

tcitworld commented Sep 26, 2016

Copy link
Copy Markdown
Member

I can squash mine for what it's worth, but I guess you don't want all of them squashed.

@LukasReschke

LukasReschke commented Sep 27, 2016

Copy link
Copy Markdown
MemberAuthor

Let's get this in 👍

@LukasReschke
LukasReschke merged commit 06e969c into masterSep 27, 2016
@LukasReschke
LukasReschke deleted the oc-public-sharing branch September 27, 2016 16:51
@georgehrke

georgehrke commented Sep 28, 2016

Copy link
Copy Markdown
Member

Thanks everyone who helped and thanks a lot to @tcitworld :)

@rullzerrullzer mentioned this pull request Nov 4, 2016
Closed
@vasyugan

vasyugan commented Dec 21, 2016

Copy link
Copy Markdown

Is this in NC 11?

@nickvergessen

nickvergessen commented Dec 21, 2016

Copy link
Copy Markdown
Member

yes

@georgehrke

georgehrke commented Dec 21, 2016

Copy link
Copy Markdown
Member

Yes, it is

@tcitworld

tcitworld commented Dec 21, 2016

Copy link
Copy Markdown
Member

You guys are too fast for me.

@LukasReschke

LukasReschke commented Dec 21, 2016

Copy link
Copy Markdown
MemberAuthor

Yes

@blizzz

blizzz commented Dec 21, 2016

Copy link
Copy Markdown
Member

да

@jospoortvliet

jospoortvliet commented Dec 21, 2016

Copy link
Copy Markdown
Member

No!

Wait, what?

👍

@tcitworldtcitworld mentioned this pull request Aug 13, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developingWork in progress

Projects

None yet

Milestone

Nextcloud 11.0

Development

Successfully merging this pull request may close these issues.

10 participants

@LukasReschke@mention-bot@tcitworld@MorrisJobke@georgehrke@vasyugan@nickvergessen@blizzz@jospoortvliet@DeepDiver1975