Uh oh!
There was an error while loading. Please reload this page.
Populate the mention-notification with the actual message - #12009
Conversation
rullzer
left a comment
There was a problem hiding this comment.
🚀
Quick smoke tests looks awesome
Signed-off-by: Joas Schilling <coding@schilljs.com>
1d35217 to
d295ff5Compare
blizzz
left a comment
There was a problem hiding this comment.
I did not include the whole message initially to avoid leaking content wherever it may show up. It seems to be the state of the art across apps though, to display it immediately.
In itself it looks good. However, the notifications app itself does not seem to pull notifications (git master), I never see anything… thus, cannot really smoke test. The prepare() method is not being entered either.
blizzz
left a comment
There was a problem hiding this comment.
However, the notifications app itself does not seem to pull notifications (git master), I never see anything… thus, cannot really smoke test. The prepare() method is not being entered either. Another make build-js was missing… works!
juliusknorr
commented
Oct 31, 2018
@blizzz Maybe a bit to early, unit tests are failing on master: |
blizzz
commented
Oct 31, 2018
damn, scrolled to far and waived it off as unrelated noise :( |
blizzz
commented
Oct 31, 2018
Let me have a quick look about adjusting those tests, as they don't seem to be fundamentally broken |
blizzz
commented
Oct 31, 2018
take a few minutes more, I add a reverting PR. Sorry for the mess. |
blizzz
commented
Oct 31, 2018
@nickvergessen can you reopen with adjusted tests, please? |
Write a comment where you mention a user on a shared file.
The notification so far only says you where mentioned.
Now it includes the text of the comment (as plain text).
With nextcloud/notifications#190 it will also be parsed and the mentions should be clickable (if there where more than your own).