Skip to content

LDAP: announce display name changes so that addressbook picks it up - #12054

Merged
rullzer merged 2 commits into
masterfrom
fix/5212/interact-with-userobject
Oct 30, 2018
Merged

LDAP: announce display name changes so that addressbook picks it up#12054
rullzer merged 2 commits into
masterfrom
fix/5212/interact-with-userobject

Conversation

@blizzz

@blizzzblizzz commented Oct 25, 2018

Copy link
Copy Markdown
Member

fixes#9112 (and refs #5212)

Test is:

  1. Have LDAP enabled and configured
  2. Ensure User A and B show up on users page
  3. As User A (or admin, does not matter), look up User B in the contacts menu on the upper right
  4. Change the displayName of User B in LDAP
  5. Log in as User B to ensure the displayname is fetched from LDAP and updated
  6. Again as User A look up User B again.

Now the new displayname should be presented, previously it did not.

@nextcloud/ldap

@blizzz
only write when the displayname differs, but then announce it
bbe4410
refs #5212 and fixes#9112
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 15 milestone Oct 25, 2018
@blizzzblizzz mentioned this pull request Oct 25, 2018
Closed
MorrisJobke
MorrisJobke approved these changes Oct 26, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@blizzz

blizzz commented Oct 26, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Causes Doctrine\\DBAL\\Exception\\UniqueConstraintViolationException","Message":"An exception occurred while executing 'INSERT INTO \"oc_accounts\" on the integratiion test, just … how and why? Cannot reproduce it locally.

UPDATE: I have a plausible theory now. This is corndered by some setup bits: 5 tables should not contain data about the certain user, cron mode must be ajax and no memcache must be set up. could reproduce.

@blizzzblizzz added 2. developing Work in progress 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 2. developing Work in progress labels Oct 26, 2018
@blizzz

blizzz commented Oct 26, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Should do now. Happy about the integration tests catching this beast :)

@rullzer

rullzer commented Oct 29, 2018

Copy link
Copy Markdown
Member

CI is not happy

@blizzz
do not run into UniqueConstraintViolationException
49456e4
… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzzforce-pushed the fix/5212/interact-with-userobject branch from 9adf542 to 49456e4CompareOctober 30, 2018 11:12
@blizzz

blizzz commented Oct 30, 2018

Copy link
Copy Markdown
MemberAuthor

Indeed, I missed to adjust the tests with the last commit.

@rullzer
rullzer merged commit 8b2b238 into masterOct 30, 2018
@rullzer
rullzer deleted the fix/5212/interact-with-userobject branch October 30, 2018 12:38
@blizzzblizzz mentioned this pull request Oct 30, 2018
Closed
blizzz added a commit that referenced this pull request Oct 30, 2018
@blizzz
Backport of#12054to stable14
bdb8e37
only write when the displayname differs, but then announce it
refs #5212 and fixes#9112
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
do not run into UniqueConstraintViolationException
… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz mentioned this pull request Oct 30, 2018
Merged
blizzz added a commit that referenced this pull request Oct 30, 2018
@blizzz
Backport of#12054to stable13
908e6be
only write when the displayname differs, but then announce it
refs #5212 and fixes#9112
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
do not run into UniqueConstraintViolationException
… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz mentioned this pull request Oct 30, 2018
Merged
@blizzzblizzz mentioned this pull request Nov 1, 2018
Closed
@fflorentfflorent mentioned this pull request Feb 22, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@GitHubUser4234GitHubUser4234Awaiting requested review from GitHubUser4234

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

Nextcloud 13: User changes do not get displayed

3 participants

@blizzz@rullzer@MorrisJobke