Uh oh!
There was an error while loading. Please reload this page.
fix - Add to favorites not working in IE11 - polyfill needed #12007 - #12083
fix - Add to favorites not working in IE11 - polyfill needed #12007#12083z0iberg wants to merge 2 commits into
Conversation
violoncelloCH
commented
Oct 28, 2018
consider #12007 (comment) by @Req before merging this |
juliusknorr
commented
Oct 29, 2018
I would rather vote to add a more complete ES6 polyfill or fix the occurenced of https://github.com/paulmillr/es6-shim might be an oppinion. We currently already have a es6-promise polyfill (which is included unminified and has about 32kb) es6-shim has a minified size of 55kb. cc @nextcloud/javascript |
juliusknorr
commented
Nov 6, 2018
As discussed I've created a pr to add es6-shim in #12317 however for backporting, i would just use the startsWith polyfill from this PR to keep the stable branches clean from the dependency change. cc @nextcloud/javascript |
juliusknorr
commented
Nov 7, 2018
MorrisJobke
commented
Nov 7, 2018
@juliushaertl Didn't we want to backport this one to stable14? |
juliusknorr
commented
Nov 7, 2018
@MorrisJobke Backport of this in #12339 |
Fix issue that has @Req. This commit was proposed by @Req, but he doesn't make this commit.
#12007 (comment)