Skip to content

remove unneeded empty LDAP search attribute values - #12107

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/12086/no-unintentional-empty-attributes
Oct 29, 2018
Merged

remove unneeded empty LDAP search attribute values#12107
MorrisJobke merged 1 commit into
masterfrom
fix/12086/no-unintentional-empty-attributes

Conversation

@blizzz

Copy link
Copy Markdown
Member

fixes#12086

@jlehtoranta@MrManor@PaulLebmann this should fix the issue as you described it. Would be great if you can test and confirm it is working again.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@MrManor

Copy link
Copy Markdown

Works for me! Thanks. (Only one file DL and tested as have have no user_ldap/tests catalog in my install)

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@MorrisJobke
MorrisJobke merged commit 76c3185 into masterOct 29, 2018
@MorrisJobke
MorrisJobke deleted the fix/12086/no-unintentional-empty-attributes branch October 29, 2018 16:00
@violoncelloCH

violoncelloCH commented Oct 29, 2018

Copy link
Copy Markdown
Member

should this be backported to 14 stable? #12086 seems to make it impossible to use Nextcloud in combination with these LDAP-Servers. Or is the range of users affected small enough?
sorry, overlooked the label

@MorrisJobke

Copy link
Copy Markdown
Member

should this be backported to 14 stable? #12086 seems to make it impossible to use Nextcloud in combination with these LDAP-Servers. Or is the range of users affected small enough?

Yes - we already added the backport-request label and this will be back ported within the next days. 👍

@blizzz

Copy link
Copy Markdown
MemberAuthor

backport PRs are opened

@kesselb

Copy link
Copy Markdown
Contributor

Is 0 a valid value for ldapQuotaAttribute? empty(0) would evaluate to true.

@blizzz

Copy link
Copy Markdown
MemberAuthor

Is 0 a valid value for ldapQuotaAttribute? empty(0) would evaluate to true.

If I understand it correctly, an attribute's name at least is one UTF-8 character, so "0" seems possible. However, it is beyond practice to use numbers as attribute names, especially 0 → it is not relevant.

@PaulLebmann

Copy link
Copy Markdown

Works for me too! Thanks a lot!!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LDAP is not working with the latest 389 Directory Server

7 participants

@blizzz@MrManor@violoncelloCH@MorrisJobke@kesselb@PaulLebmann@rullzer