Uh oh!
There was an error while loading. Please reload this page.
Reset bruteforce on token refresh OAuth - #12130
Merged
Merged
Conversation
Dagefoerde
approved these changes
Oct 30, 2018
Dagefoerde
left a comment
Member
There was a problem hiding this comment.
I suppose this mitigates the current problem with the brute force protection. #12131 still required as it would solve the actual problem.
rullzer
requested review from
ChristophWurst, MorrisJobke, blizzz and schiessleOctober 30, 2018 09:28
ChristophWurst
approved these changes
Oct 30, 2018
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Looks good and changes make sense!
MorrisJobke
commented
Oct 30, 2018
Member
Unit tests fail. |
When using atoken obtained via OAuth the token expires. Resulting in brute force attempts hitting the requesting IP. This resets the brute force attempts for that UID on a valid refresh of the token. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
fix/reset_bruteforce_oauth
branch
from
October 30, 2018 10:21
33f2862 to
75456b0Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using atoken obtained via OAuth the token expires. Resulting in
brute force attempts hitting the requesting IP.
This resets the brute force attempts for that UID on a valid refresh of
the token.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl