Skip to content

suppress wrong audit log messages about failed login attempts - #12148

Merged
rullzer merged 1 commit into
masterfrom
suppress-wrong-audit-log-message
Nov 2, 2018
Merged

suppress wrong audit log messages about failed login attempts#12148
rullzer merged 1 commit into
masterfrom
suppress-wrong-audit-log-message

Conversation

@schiessle

Copy link
Copy Markdown
Member

first check if the user is already logged in and then try to authenticate via apache, this way we suppress wrong audit log messages about failed login attempts

followup on nextcloud/user_saml#254 to suppress the last remaining message

fix#11269

@schiessleschiessle added 3. to review Waiting for reviews bug labels Oct 30, 2018
…cate via apache, this way we suppress wrong audit log messages about failed login attempts
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@schiessle
schiessleforce-pushed the suppress-wrong-audit-log-message branch from 44a58a9 to 0efd29fCompareOctober 30, 2018 21:15
@LukasReschke

Copy link
Copy Markdown
Member

🙊🙉🙈

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke

Copy link
Copy Markdown
Member

CI failure is unrelated and is fixed by a hardening by @danxuliu

@rullzer
rullzer merged commit 7ba8700 into masterNov 2, 2018
@rullzer
rullzer deleted the suppress-wrong-audit-log-message branch November 2, 2018 12:52
@MorrisJobke

Copy link
Copy Markdown
Member

@schiessle Mind to backport?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAML SSO generates many “Login attempts” in audit.log

4 participants

@schiessle@LukasReschke@MorrisJobke@rullzer