Skip to content

Fix Calendarsubscriptions source column change on Oracle - #12275

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/11975/oracle_calendar_subscriptions_source
Nov 13, 2018
Merged

Fix Calendarsubscriptions source column change on Oracle#12275
MorrisJobke merged 1 commit into
masterfrom
bugfix/11975/oracle_calendar_subscriptions_source

Conversation

@georgehrke

@georgehrkegeorgehrke commented Nov 5, 2018

Copy link
Copy Markdown
Member

fixes#11975

@georgehrkegeorgehrke added this to the Nextcloud 15 milestone Nov 5, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Nov 6, 2018
Merged
29 tasks
ChristophWurst
ChristophWurst previously requested changes Nov 7, 2018
View reviewed changes
Comment threadapps/dav/lib/Migration/Version1008Date20181105104826.php Outdated
Comment threadapps/dav/lib/Migration/Version1008Date20181105104826.php Outdated
Comment threadapps/dav/lib/Migration/Version1008Date20181105104833.php Outdated
Comment threadapps/dav/lib/Migration/Version1008Date20181105104833.php Outdated
Comment threadapps/dav/lib/Migration/Version1008Date20181105110300.php Outdated
Comment threadapps/dav/lib/Migration/Version1008Date20181105112049.php Outdated
Comment threadapps/dav/lib/Migration/Version1008Date20181105112049.php Outdated
Comment threadapps/dav/lib/Migration/Version1007Date20181007225117.php
nickvergessen
nickvergessen reviewed Nov 7, 2018
View reviewed changes
Comment threadapps/dav/appinfo/info.xml Outdated
<summary>WebDAV endpoint</summary>
<description>WebDAV endpoint</description>
<version>1.7.2</version>
<version>1.8.0</version>

@nickvergessennickvergessenNov 7, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.7.3 should be fine, I increase it directly after each major release 🙈

nickvergessen
nickvergessen previously requested changes Nov 7, 2018
View reviewed changes
Comment threadapps/dav/lib/Migration/Version1008Date20181105104826.php Outdated
Comment threadapps/dav/lib/Migration/Version1008Date20181105104826.php Outdated
@georgehrke
georgehrkeforce-pushed the bugfix/11975/oracle_calendar_subscriptions_source branch from fcfcd1b to b6e6308CompareNovember 7, 2018 12:57
@georgehrke

georgehrke commented Nov 7, 2018

Copy link
Copy Markdown
MemberAuthor

Set version to 1.7.3 and removed the extra checks.

@georgehrke
georgehrke dismissed stale reviews from nickvergessen and ChristophWurstNovember 7, 2018 12:58

All remarks have been addressed

ChristophWurst
ChristophWurst requested changes Nov 7, 2018
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible I'd suggest to do a column rename instead of the second copy. Apart from that it looks good!

Comment threadapps/dav/lib/Migration/Version1008Date20181105104826.php Outdated
Comment threadapps/dav/lib/Migration/Version1008Date20181105104833.php Outdated
Comment threadapps/dav/lib/Migration/Version1008Date20181105110300.php Outdated
@georgehrke
georgehrkeforce-pushed the bugfix/11975/oracle_calendar_subscriptions_source branch from b6e6308 to fa34a6bCompareNovember 7, 2018 13:18
ChristophWurst
ChristophWurst requested changes Nov 7, 2018
View reviewed changes
Comment threadapps/dav/lib/Migration/Version1008Date20181105110300.php
@georgehrke

This comment has been minimized.

Sign in to view
@georgehrke

This comment has been minimized.

Sign in to view
@ChristophWurst

This comment has been minimized.

Sign in to view
ChristophWurst
ChristophWurst approved these changes Nov 7, 2018
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skjnldsv

skjnldsv commented Nov 7, 2018

Copy link
Copy Markdown
Member

I just realized the naming of the files is : Version1008Datexxx which probably means version 10.0.8. :D

@georgehrke

georgehrke commented Nov 7, 2018

Copy link
Copy Markdown
MemberAuthor

I named it Version1008..., because there is already another migration starting with Version1008... and i wanted to keep the order right.

@nickvergessen

nickvergessen commented Nov 7, 2018•
edited
Loading

Copy link
Copy Markdown
Member

I just realized the naming of the files is : Version1008Datexxx which probably means version 10.0.8.

No, if the version is X.Y.Z the migration name is XXXYYY without leading zeros of X

@MorrisJobkeMorrisJobke added bug 3. to review Waiting for reviews labels Nov 7, 2018
blizzz
blizzz reviewed Nov 7, 2018
View reviewed changes
Comment threadapps/dav/lib/Migration/Version1008Date20181105104826.php Outdated
@georgehrke
georgehrkeforce-pushed the bugfix/11975/oracle_calendar_subscriptions_source branch from fa34a6b to 886e707CompareNovember 7, 2018 16:40
@MorrisJobkeMorrisJobke mentioned this pull request Nov 8, 2018
Merged
24 tasks
@MorrisJobke
MorrisJobkeforce-pushed the bugfix/11975/oracle_calendar_subscriptions_source branch from 886e707 to a72713cCompareNovember 12, 2018 11:09
@MorrisJobke

MorrisJobke commented Nov 12, 2018

Copy link
Copy Markdown
Member

Rebased to fix conflicts in autoloader.

MorrisJobke
MorrisJobke reviewed Nov 12, 2018
View reviewed changes
Comment threadapps/dav/lib/Migration/Version1008Date20181105104826.php
@georgehrke@MorrisJobke
Fix Calendarsubscriptions source column change on Oracle
071301b
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@MorrisJobke
MorrisJobkeforce-pushed the bugfix/11975/oracle_calendar_subscriptions_source branch from a72713c to 071301bCompareNovember 13, 2018 15:32
@MorrisJobke
MorrisJobke merged commit 3c5e438 into masterNov 13, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/11975/oracle_calendar_subscriptions_source branch November 13, 2018 15:34
@nickvergessennickvergessen mentioned this pull request Nov 16, 2018
Merged
@nickvergessennickvergessen mentioned this pull request Dec 5, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@MorrisJobkeMorrisJobkeMorrisJobke left review comments
@blizzzblizzzblizzz left review comments
@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

Installing on oracle fails

6 participants

@georgehrke@ChristophWurst@skjnldsv@nickvergessen@MorrisJobke@blizzz