Skip to content

Add grid toggle for every files view - #12303

Merged
skjnldsv merged 3 commits into
masterfrom
grid-for-all-file-templates
Nov 6, 2018
Merged

Add grid toggle for every files view#12303
skjnldsv merged 3 commits into
masterfrom
grid-for-all-file-templates

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Nov 6, 2018

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Nov 6, 2018
@skjnldsvskjnldsv added this to the Nextcloud 15 milestone Nov 6, 2018
@skjnldsvskjnldsv self-assigned this Nov 6, 2018
@skjnldsv
skjnldsvforce-pushed the grid-for-all-file-templates branch from a069840 to 095b88aCompareNovember 6, 2018 09:10
@MorrisJobke

MorrisJobke commented Nov 6, 2018•
edited by skjnldsv
Loading

Copy link
Copy Markdown
Member

@rullzer

rullzer commented Nov 6, 2018

Copy link
Copy Markdown
Member

For the second screenshot @jancborchardt also has an issue. I guess the wrong (small) preview is requested

@skjnldsv
Add grid toggle for every files view
5682d30
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the grid-for-all-file-templates branch from 095b88a to 5682d30CompareNovember 6, 2018 10:42
@skjnldsv
Fix min trhumbnail size
98edf36
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv

skjnldsv commented Nov 6, 2018

Copy link
Copy Markdown
MemberAuthor

All fixed

juliusknorr
juliusknorr requested changes Nov 6, 2018
View reviewed changes
Comment threadapps/files_sharing/js/public.js
@MorrisJobkeMorrisJobke mentioned this pull request Nov 6, 2018
Merged
29 tasks
MorrisJobke
MorrisJobke approved these changes Nov 6, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@juliusknorr

juliusknorr commented Nov 6, 2018

Copy link
Copy Markdown
Member

@skjnldsv One unit test failure:


There was 1 failure:
1) OCA\Files\Tests\Controller\ViewControllerTest::testIndexWithRegularBrowser
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
+ 'showgridview' => null
+ 'isIE' => false

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 6, 2018
@skjnldsv
Fix tests
cac2f7f
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the grid-for-all-file-templates branch from 7cd38ec to cac2f7fCompareNovember 6, 2018 15:05
@skjnldsv

skjnldsv commented Nov 6, 2018

Copy link
Copy Markdown
MemberAuthor

Unrelated: sh: 1: kill: No such process

@skjnldsv
skjnldsv merged commit e03bc6e into masterNov 6, 2018
@skjnldsv
skjnldsv deleted the grid-for-all-file-templates branch November 6, 2018 16:29
@danxuliudanxuliu mentioned this pull request Nov 8, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugdesignDesign, UI, UX, etc.feature: files

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@MorrisJobke@rullzer@juliusknorr