Uh oh!
There was an error while loading. Please reload this page.
Clear avatar cache with frontend repair - #12313
Merged
Merged
Conversation
skjnldsv
requested review from
ChristophWurst, MorrisJobke, danxuliu, jancborchardt, juliusknorr and rullzerNovember 6, 2018 14:45
skjnldsvforce-pushed
the
generated-avatar-major-cleanup
branch
from
November 6, 2018 14:55
959f092 to
78dd2ceComparerullzer
previously requested changes
Nov 6, 2018
Uh oh!
There was an error while loading. Please reload this page.
skjnldsvforce-pushed
the
generated-avatar-major-cleanup
branch
from
November 7, 2018 09:39
78dd2ce to
a884be4Compareskjnldsv
commented
Nov 7, 2018
MemberAuthor
Failure unrelated |
rullzer
previously requested changes
Nov 7, 2018
| * @see IAvatar | ||
| * @since 15.0.0 | ||
| */ | ||
| public function clearCachedAvatars(); |
Member
There was a problem hiding this comment.
What is this doing in the public namespace.
IMO we should just inject the private class in the repair step and keep this out of here. I see no reason for an app to trigger this.
Uh oh!
There was an error while loading. Please reload this page.
rullzer
reviewed
Nov 7, 2018
Uh oh!
There was an error while loading. Please reload this page.
skjnldsvforce-pushed
the
generated-avatar-major-cleanup
branch
from
November 7, 2018 19:37
87e581f to
1c13c34Comparerullzer
approved these changes
Nov 7, 2018
rullzer
requested changes
Nov 7, 2018
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
generated-avatar-major-cleanup
branch
from
November 8, 2018 07:31
1c13c34 to
a9eef37Comparerullzer
approved these changes
Nov 8, 2018
| new AddCleanupUpdaterBackupsJob(\OC::$server->getJobList()), | ||
| new RepairPendingCronJobs(\OC::$server->getDatabaseConnection(), \OC::$server->getConfig()), | ||
| new SetVcardDatabaseUID(\OC::$server->getDatabaseConnection(), \OC::$server->getConfig()), | ||
| new SetVcardDatabaseUID(\OC::$server->getDatabaseConnection(), \OC::$server->getConfig()) |
Member
There was a problem hiding this comment.
We always kept a trailing , in arrays to make the diff for adding a new entry nicer. It then only has this one line added instead of also appending a , to the previous line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#12058
@nextcloud/designers