Skip to content

Enable sorting in file picker - #12350

Merged
MorrisJobke merged 3 commits into
masterfrom
filepicker-sorting
Nov 20, 2018
Merged

Enable sorting in file picker#12350
MorrisJobke merged 3 commits into
masterfrom
filepicker-sorting

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Fixes#645

This allows sorting the entries in the file picker by name, size or mtime.

List view:
image

Grid view:
image

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine here!

@MorrisJobke

MorrisJobke commented Nov 13, 2018

Copy link
Copy Markdown
Member
  • header also shown in the empty file list
    bildschirmfoto 2018-11-13 um 16 27 47
  • loading spinner is placed over the header
    bildschirmfoto 2018-11-13 um 16 27 52

@MorrisJobkeMorrisJobke added this to the Nextcloud 15 milestone Nov 13, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Nov 13, 2018
24 tasks
@MorrisJobke

Copy link
Copy Markdown
Member

@juliushaertl Moved to 16, but we maybe want to back port this anyways, right?

@rullzer

Copy link
Copy Markdown
Member

@MorrisJobke yes that is right

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke Fixed.

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit a9de88e into masterNov 20, 2018
@MorrisJobke
MorrisJobke deleted the filepicker-sorting branch November 20, 2018 12:35
@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable14

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable13

@rullzer

Copy link
Copy Markdown
Member

The backport failed in a way the bot did not handle it properly. I'll look into that

@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
7 tasks
@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable14

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable13 failed. Please do this backport manually.

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

We'll not backport this for now as discussed with @MorrisJobke

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@MorrisJobke@rullzer@skjnldsv