Skip to content

Fix overlapping update button in notifications - #12354

Closed
MorrisJobke wants to merge 1 commit into
masterfrom
fix/noid/overlapping-update-notification
Closed

Fix overlapping update button in notifications#12354
MorrisJobke wants to merge 1 commit into
masterfrom
fix/noid/overlapping-update-notification

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member
  • requirements: update available & setting a non-default update server
  • before:
    bildschirmfoto 2018-11-08 um 14 17 42
  • after:
    bildschirmfoto 2018-11-08 um 14 17 37

Regarding building this I just ran make and it also properly rebuilds the JS files, but looking at the diff they look wrong.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added bug 3. to review Waiting for reviews labels Nov 8, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 15 milestone Nov 8, 2018
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Regarding building this I just ran make and it also properly rebuilds the JS files, but looking at the diff they look wrong.

Anyways I tested it in multiple browsers and it seems to be there without a problem.

@nickvergessen

Copy link
Copy Markdown
Member

Replaced with 12358

@nickvergessen
nickvergessen deleted the fix/noid/overlapping-update-notification branch November 9, 2018 09:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MorrisJobke@nickvergessen