Skip to content

Ignore icons if the file could not be found - #12420

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/icons-cacher-not-found
Nov 12, 2018
Merged

Ignore icons if the file could not be found#12420
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/icons-cacher-not-found

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Nov 12, 2018

Copy link
Copy Markdown
Member

Otherwise it will throw an ErrorException if the file is not found.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr added bug 3. to review Waiting for reviews labels Nov 12, 2018
@juliusknorrjuliusknorr added this to the Nextcloud 15 milestone Nov 12, 2018

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 👍

@MorrisJobke
MorrisJobke merged commit f6fed4d into masterNov 12, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/noid/icons-cacher-not-found branch November 12, 2018 20:13
@MorrisJobkeMorrisJobke mentioned this pull request Nov 14, 2018
24 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@MorrisJobke@skjnldsv