Skip to content

Add pipe mode for sendmail - #12424

Merged
MorrisJobke merged 3 commits into
masterfrom
feature/add-pipe-mode-for-sendmail
Nov 29, 2018
Merged

Add pipe mode for sendmail#12424
MorrisJobke merged 3 commits into
masterfrom
feature/add-pipe-mode-for-sendmail

Conversation

@kesselb

@kesselbkesselb commented Nov 12, 2018

Copy link
Copy Markdown
Contributor

Based on #11454
Close#11281

  • Removed -oi from pipe mode (i'm unsure if the switch is available on any platform)
  • Value can be changed on settings page

image

cc @cwiedmann@duke-m

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really test. But makes sense.

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 28, 2018
@kesselb

Copy link
Copy Markdown
ContributorAuthor

I will have a look at the failed tests later.

@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 28, 2018
@kesselb
kesselbforce-pushed the feature/add-pipe-mode-for-sendmail branch from 70a8396 to e84fcc3CompareNovember 28, 2018 19:08
@kesselb

Copy link
Copy Markdown
ContributorAuthor

@rullzer@MorrisJobke mind to review again? Tests are working for me now.

cwiedmannand others added 3 commits November 29, 2018 16:02
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the feature/add-pipe-mode-for-sendmail branch from 1b46f04 to 4a2c56bCompareNovember 29, 2018 15:02
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 29, 2018

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't test but code looks good!

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit ee2cb46 into masterNov 29, 2018
@MorrisJobke
MorrisJobke deleted the feature/add-pipe-mode-for-sendmail branch November 29, 2018 16:43
@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable15

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #12736

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable14

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable14 failed. Please do this backport manually.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kesselb@MorrisJobke@rullzer@ChristophWurst@cwiedmann