Uh oh!
There was an error while loading. Please reload this page.
[stable14] Fix missing quickaccess favorite folder on add - #12441
Merged
Conversation
…added to favorites Signed-off-by: fnuesse <felix.nuesse@t-online.de>
MorrisJobke
requested review from
ChristophWurst, juliusknorr, kesselb, rullzer and skjnldsvNovember 14, 2018 07:46
Merged
kesselb
approved these changes
Nov 14, 2018
| * | ||
| * @NoAdminRequired | ||
| * | ||
| * @param String |
Contributor
There was a problem hiding this comment.
String => string (http://docs.phpdoc.org/guides/types.html)
| * | ||
| * @param String | ||
| * @return String | ||
| */ |
Contributor
There was a problem hiding this comment.
Please add @throws NotFoundException because get($folderpath)
server/lib/public/Files/Folder.php
Lines 77 to 85 in 39bb32a
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
commented
Nov 14, 2018
Member
@danielkesselberg I will port the fixes to your comments to master as well. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to NC14 of #10888
When you mark a folder as favorite, it should be added to the quickaccessbar. This is not the case, because the route for checking if the newly marked element is a folder or a directory is missing. This PR readds the missing route.