Skip to content

Throw exception if decryption fails - #12450

Merged
rullzer merged 1 commit into
masterfrom
fix/11868/decryption_hardening
Nov 14, 2018
Merged

Throw exception if decryption fails#12450
rullzer merged 1 commit into
masterfrom
fix/11868/decryption_hardening

Conversation

@rullzer

Copy link
Copy Markdown
Member

For #11868

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

For #11868
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added the 3. to review Waiting for reviews label Nov 14, 2018
@rullzerrullzer added this to the Nextcloud 15 milestone Nov 14, 2018

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better ¯\_(ツ)_/¯

@nickvergessen

Copy link
Copy Markdown
Member

SHould we backport this, because of the type hinting?

@rullzer

Copy link
Copy Markdown
MemberAuthor

Backport should be safe

@rullzer
rullzer merged commit c414bd1 into masterNov 14, 2018
@rullzer
rullzer deleted the fix/11868/decryption_hardening branch November 14, 2018 18:34
@MorrisJobkeMorrisJobke mentioned this pull request Nov 14, 2018
24 tasks
@rullzer

Copy link
Copy Markdown
MemberAuthor

/backport to stable14

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable14 in #12540

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@nickvergessen@ChristophWurst