Skip to content

Remove conflicting multiselect - #12468

Merged
skjnldsv merged 1 commit into
masterfrom
multiselect-removal-fix
Nov 22, 2018
Merged

Remove conflicting multiselect#12468
skjnldsv merged 1 commit into
masterfrom
multiselect-removal-fix

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Nov 15, 2018

Copy link
Copy Markdown
Member

See #1831
@blizzz can you check the ldap please?

It should be using the other jQuery ui multiselect, this is the last location I could find where it was being used :)

@nextcloud/designers

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added bug design Design, UI, UX, etc. 2. developing Work in progress labels Nov 15, 2018
@skjnldsvskjnldsv self-assigned this Nov 15, 2018
@skjnldsv
skjnldsv requested a review from blizzzNovember 15, 2018 13:12
@MorrisJobke

Copy link
Copy Markdown
Member

Should this be in 15? Or better wait for 16?

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke ideally 15. But if this is too complicated, i'll add a stricter css rule to backport it to 15 and make sure we ignore this conflict :)

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

I was able to complete the full setup and use the multiselect without any issues. The multiselect in core have nothing to do with the multiselect used in the ldap config
Let's review!

@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 15, 2018
@skjnldsvskjnldsv added this to the Nextcloud 15 milestone Nov 15, 2018

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with rg multiselect -g \!3rdparty -t js -M 150 and couldn't find any occurences of a multiselect apart from the Vue one.

👍 (50% 🐘)

@MorrisJobke

MorrisJobke commented Nov 20, 2018

Copy link
Copy Markdown
Member

I'm unsure if we should do this that late in the cycle. Also it looks like ldap is depending on this. It seems there is a second multiselect in LDAP. I tested it as well and it still works fine.

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@MorrisJobke

Copy link
Copy Markdown
Member

I'm unsure if we should do this that late in the cycle.

I would like to get some feedback from @juliushaertl@rullzer and @nickvergessen about this.

@rullzer

Copy link
Copy Markdown
Member

It seems to work. Let's do it to avoid weird patches.

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 21, 2018
@skjnldsv
skjnldsv merged commit 654880d into masterNov 22, 2018
@skjnldsv
skjnldsv deleted the multiselect-removal-fix branch November 22, 2018 07:49
@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugdesignDesign, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@MorrisJobke@rullzer@ChristophWurst