Uh oh!
There was an error while loading. Please reload this page.
Fix navigation layout for items that are added on a re-render - #12481
Merged
MorrisJobke merged 1 commit intoNov 16, 2018
Conversation
nickvergessen
requested review from
MorrisJobke, jancborchardt, juliusknorr and skjnldsvNovember 16, 2018 09:56
skjnldsv
approved these changes
Nov 16, 2018
skjnldsv
commented
Nov 16, 2018
Member
Fix #12464 ? |
MorrisJobke
commented
Nov 16, 2018
Member
Already added ;) |
rullzer
approved these changes
Nov 16, 2018
MorrisJobke
commented
Nov 16, 2018
Member
I don't get it. For me the code is locally executed but the result still looks wrong:
I refreshed multiple times, reinstalled, used different browsers ... and still - the newly added apps are still rendered wrongly. So this does not fix #12481 somehow. for me. |
skjnldsvforce-pushed
the
bugfix/noid/fix-navigation-layout-of-new-items
branch
from
November 16, 2018 11:06
10cd800 to
4604a74Compareskjnldsv
approved these changes
Nov 16, 2018
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Done.
The span is next to the a, not within it.
I also fixed the size of the apps icons that did not reflect what the php was initially outputting.
Signed-off-by: Joas Schilling <coding@schilljs.com>
skjnldsvforce-pushed
the
bugfix/noid/fix-navigation-layout-of-new-items
branch
from
November 16, 2018 11:08
4604a74 to
44b0d39CompareMorrisJobke
deleted the
bugfix/noid/fix-navigation-layout-of-new-items
branch
November 16, 2018 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug was not visible until #12153
Now it looks awkward with the externals app
Fixes#12464