Skip to content

Fix loader colours for better visibility - #12484

Merged
MorrisJobke merged 1 commit into
masterfrom
loader-color-fixes
Nov 16, 2018
Merged

Fix loader colours for better visibility#12484
MorrisJobke merged 1 commit into
masterfrom
loader-color-fixes

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Nov 16, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Fix#12091

Before
capture d ecran_2018-11-16_13-39-37
After
capture d ecran_2018-11-16_13-39-06
@nextcloud/designers

@skjnldsv
Fix loader colours for better visibility
8054368
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: accessibility labels Nov 16, 2018
@skjnldsvskjnldsv added this to the Nextcloud 15 milestone Nov 16, 2018
@skjnldsvskjnldsv self-assigned this Nov 16, 2018
JanDragon
JanDragon approved these changes Nov 16, 2018
View reviewed changes

@JanDragonJanDragon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristophWurst

ChristophWurst commented Nov 16, 2018

Copy link
Copy Markdown
Member

better visibility

How's this better when the contrast decreases?

@skjnldsv

skjnldsv commented Nov 16, 2018

Copy link
Copy Markdown
MemberAuthor

@ChristophWurst on which location would the contrast be decreased?
You mean like background-dark/darker?

@MorrisJobke

MorrisJobke commented Nov 16, 2018

Copy link
Copy Markdown
Member

@ChristophWurst on which location would the contrast be decreased?
You mean like background-dark/darker?

For the lower left image ... 🤔

@ChristophWurst

ChristophWurst commented Nov 16, 2018

Copy link
Copy Markdown
Member

Thought the spinner itself was made darker but it's actually the background, right? (Don't know where that css var is used)

@skjnldsv

skjnldsv commented Nov 16, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Thought the spinner itself was made darker but it's actually the background, right? (Don't know where that css var is used)

It's the dark part of the spinner that got darker to increase the contrast between the light part and the dark.

juliusknorr
juliusknorr approved these changes Nov 16, 2018
View reviewed changes

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍

MorrisJobke
MorrisJobke approved these changes Nov 16, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke
MorrisJobke merged commit 8a5ac26 into masterNov 16, 2018
@MorrisJobke
MorrisJobke deleted the loader-color-fixes branch November 16, 2018 13:53
@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
Merged
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@JanDragonJanDragonJanDragon approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: accessibility

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@ChristophWurst@MorrisJobke@juliusknorr@JanDragon