Skip to content

Remove unused svg api route - #12487

Merged
skjnldsv merged 1 commit into
masterfrom
settings-svg-icons-scss-fix
Nov 16, 2018
Merged

Remove unused svg api route#12487
skjnldsv merged 1 commit into
masterfrom
settings-svg-icons-scss-fix

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Nov 16, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Fix#12397

@rso42

I could not find anywhere where we use this route.
I think this was a start I added in #9984, but did not continued with this path and used the getSvgFromApp instead 29ff7ef#diff-6f74898d9cb1171c9d9a8f925434de55R81 🤷‍♀️

@skjnldsv
Remove unused sg api route
2eba5f9
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added this to the Nextcloud 15 milestone Nov 16, 2018
@skjnldsvskjnldsv self-assigned this Nov 16, 2018
@skjnldsvskjnldsv changed the title Remove unused sg api routeRemove unused svg api routeNov 16, 2018
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 16, 2018
@skjnldsv

skjnldsv commented Nov 16, 2018

Copy link
Copy Markdown
MemberAuthor

Failure unrelated

@skjnldsv
skjnldsv merged commit 1942280 into masterNov 16, 2018
@skjnldsv
skjnldsv deleted the settings-svg-icons-scss-fix branch November 16, 2018 15:23
@rullzer

rullzer commented Nov 19, 2018

Copy link
Copy Markdown
Member

/backport to stable14

@skjnldsvskjnldsv mentioned this pull request Nov 20, 2018
Merged
@skjnldsv

skjnldsv commented Nov 20, 2018

Copy link
Copy Markdown
MemberAuthor

Backport in #12542

@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
Merged
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@rullzer@juliusknorr