Uh oh!
There was an error while loading. Please reload this page.
Only use width and opacity for transition - #12489
Merged
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
MorrisJobke
approved these changes
Nov 16, 2018
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Tested, works and fixes the CPU issue on safari
JanDragon
approved these changes
Nov 16, 2018
JanDragon
left a comment
There was a problem hiding this comment.
Tested in Real Mac Os Safari. Works Perfect.
MorrisJobke
commented
Nov 16, 2018
Member
@juliushaertl Could you port this to stable14? I would say it's fine to put it in 14.0.4 still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This probably fixes#11179
I tried to debug this a bit using browserstack, and it seems to fix the continuous rerendering, which was caused by the transition: all 100ms; rule.
@MorrisJobke Would be great if you could give this a try on a real Safari.