Skip to content

Fix share link password input - #12491

Merged
skjnldsv merged 1 commit into
masterfrom
share-menu-click-fix
Nov 20, 2018
Merged

Fix share link password input#12491
skjnldsv merged 1 commit into
masterfrom
share-menu-click-fix

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Nov 16, 2018

Copy link
Copy Markdown
Member

Fix#12308

Better layout, now clicking outside (which is often supposed to be a cancel action) won't do anything now.
Direct validation by enter key or click is what we want.

peek 16-11-2018 16-18

Also fixed the loading on the sharees autocompletion

BeforeAfter
capture d ecran_2018-11-16_15-55-41capture d ecran_2018-11-16_15-57-00

@skjnldsvskjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Nov 16, 2018
@skjnldsvskjnldsv added this to the Nextcloud 15 milestone Nov 16, 2018
@skjnldsvskjnldsv self-assigned this Nov 16, 2018
@skjnldsv

skjnldsv commented Nov 20, 2018

Copy link
Copy Markdown
MemberAuthor

Bump!

ChristophWurst
ChristophWurst approved these changes Nov 20, 2018
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

MorrisJobke
MorrisJobke approved these changes Nov 20, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke

MorrisJobke commented Nov 20, 2018

Copy link
Copy Markdown
Member

JSUnit test fails:

PhantomJS 2.1.1 (Linux 0.0.0) OC.Share.ShareDialogView Share with link update password on focus out FAILED
Expected false to equal true.
core/js/tests/specs/sharedialogviewSpec.js:146:48
TypeError: null is not an object (evaluating 'saveLinkShareStub.firstCall.args') in core/js/tests/specs/sharedialogviewSpec.js (line 147)
core/js/tests/specs/sharedialogviewSpec.js:147:38

@skjnldsv
Fix share link password input
7a9ea03
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 20, 2018
@skjnldsv

skjnldsv commented Nov 20, 2018

Copy link
Copy Markdown
MemberAuthor

JSunit ok: https://drone.nextcloud.com/nextcloud/server/12855/287
Failure unrelated

@skjnldsv
skjnldsv merged commit ebc690b into masterNov 20, 2018
@skjnldsv
skjnldsv deleted the share-menu-click-fix branch November 20, 2018 14:35
@nextcloud-botnextcloud-bot mentioned this pull request Nov 20, 2018
Closed
@skjnldsvskjnldsv mentioned this pull request Nov 20, 2018
Merged
@skjnldsv

skjnldsv commented Nov 20, 2018

Copy link
Copy Markdown
MemberAuthor

Backport: #12560

@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
Merged
7 tasks
@MorrisJobkeMorrisJobke mentioned this pull request May 7, 2019
Closed
@nextcloud-botnextcloud-bot mentioned this pull request Nov 16, 2018
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@jancborchardtjancborchardtjancborchardt approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugdesignDesign, UI, UX, etc.high

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

can't see the warning about a wrong password when sharing by email

4 participants

@skjnldsv@MorrisJobke@jancborchardt@ChristophWurst