Skip to content

forward object not found error in swift as dav 404 - #12500

Merged
MorrisJobke merged 2 commits into
masterfrom
swift-object-not-found
Nov 20, 2018
Merged

forward object not found error in swift as dav 404#12500
MorrisJobke merged 2 commits into
masterfrom
swift-object-not-found

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

Comment threadlib/private/Files/ObjectStore/ObjectStoreStorage.php Outdated

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

Signed-off-by: Robin Appelman <robin@icewind.nl>
@rullzer

Copy link
Copy Markdown
Member

Should we also add this for S3?

@kesselb

Copy link
Copy Markdown
Contributor

/**
* @param string $urn the unified resource name used to identify the object
* @return resource stream with the read data
* @throws \Exception when something goes wrong, message will be logged
* @since 7.0.0
*/
publicfunctionreadObject($urn);

For nextcloud15 the interface should be adjusted. @throws NotFoundException if file does not exist

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
Member

For nextcloud15 the interface should be adjusted. @throws NotFoundException if file does not exist

Added 👍

@MorrisJobke
MorrisJobke merged commit 8e65f08 into masterNov 20, 2018
@MorrisJobke
MorrisJobke deleted the swift-object-not-found branch November 20, 2018 08:50
@MorrisJobkeMorrisJobke mentioned this pull request Nov 22, 2018
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991@rullzer@kesselb@MorrisJobke