Uh oh!
There was an error while loading. Please reload this page.
[stable14] Fix the warning appearing in the admin section when mail_smtpmode is not configured - #12529
Merged
Conversation
MorrisJobke
requested review from
danxuliu, kesselb, kyrofa, rullzer and skjnldsvNovember 19, 2018 14:31
Merged
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobkeforce-pushed
the
backport/12401/php-warning
branch
from
November 19, 2018 14:49
f719750 to
511eadeCompareskjnldsv
approved these changes
Nov 19, 2018
kyrofa
approved these changes
Nov 19, 2018
kyrofa
left a comment
Member
There was a problem hiding this comment.
Just tested, works as expected 👍 . Thanks @MorrisJobke!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12401
I would port this to 14.0.4 (as we need an RC 2 for #12502 anyways) and because this blocks that stable14 is shipped via snap by @kyrofa. Also this is a change of one default attribute in the setup check and has little impact on the overall instance.